-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ripley numpy #54
Ripley numpy #54
Conversation
OK, the notebook showing the translation from the old to new API is chugging along is chugging along. I'd still like to
|
I've completed tests for all the helper functions, but still need to write the correctness tests. I also need to document the hulls. |
Tests are now in place and they're pretty comprehensive (if the backlog of commits is anything to show for it :) I just need to document the hull logic in a notebook & then we're done. |
Locally, this works for all the tests, and fails for some of the Knox statistics I didn't touch... not sure what's up there? We'll have to see in travis, but I think this is rtg. Documentation can be added later to beef up the info on the simulator alternatives. While we should deprecate those (I think) I'm much less interested in doing so because they're performant. |
OK, well, I'm not sure how to get the specification correct for travis, but tests pass locally aside from the Knox stuff (which I haven't touched). This is ready for review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is excellent.
Locally everything passes, except the Knox test as you are finding.
I can try to move forward with debugging the travis issues.
See if this solution addresses the travis issues. |
@ljwolf do you think this is the way we should go on the testing? Yesterday at the dev meeting we briefly mentioned this but I wanted to circle back in case it got lost in the flurry of activity. If it is the way forward, please merge that pr into your branch, which will update this pr and i think have the tests pass. |
Ripley numpy
Yes! Sorry, took the recommendation and merged it! I forgot about it when tinkering around today. |
migration of pysal/esda#115